AsyncLabs Forums

[GregEigsti]

Thanks for the fix (even if you are an a-hole)
What about something like this to grab what we can (which could mean incomplete/partial packet) instead of discarding the entire packet. A partial packet could cause more confusion in the end...

Code: Select all

spi_transfer(zg_buf, rx_byte_cnt + 1 < (U16)UIP_BUFSIZE ? rx_byte_cnt + 1 : (U16)UIP_BUFSIZE, 1);


Greg

[aerodyno]

Hi guys,

I'm going to try this fix now. I'll see if it breaks existing functionality (can't imagine it would) and I should have a test within a week or two with a Verizon FIOS router.

-s

[spidermonkey04]

I just noticed that accepting an incomplete packet won't help much. uIP checks the length reported in the IP header against what is actually there, so it would be dropped right after being copied into the buffer anyway.

---Jared

[GregEigsti]

Yeah I'm siding with you on that one - even if not rejected by some other mechanism a partial packet would likely be more trouble that its worth. Your "remove the entire" packet fix is part of the user contrib branch

Greg

[aerodyno]

Note, an updated discussion on this fix is here:

viewtopic.php?f=23&t=432&p=2896&hilit=large+packet#p2896

-s